Skip to content

Conversation

@stephanosio
Copy link
Member

@stephanosio stephanosio commented Sep 8, 2022

This series updates the CI to use Clang 15 for building tests.

It also includes some additional clean-up patches removing the stale Clang-related variable references.

Workflow clean-up changes tested in: https://github.com/zephyrproject-rtos/zephyr-testing/actions/runs/3016985929
Clang 15 build tested in: https://github.com/zephyrproject-rtos/zephyr-testing/actions/runs/3016991983

Clang 15 added a new warning type `-Wdeprecated-non-prototype` that
warns about the functions without prototypes, which have been
deprecated since the C89 and will not work in the upcoming C2x.

This commit disables the warning because Zephyr deliberately makes use
of the functions without prototypes to allow the use of a "generic"
function pointer (notoriously in the cbprintf implementation) and
Zephyr will not move to the C2x in the foreseeable future.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit removes stale clang-related variables that are not used by
the Twister workflow.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit removes stale clang-related variables that are not used by
the codecov workflow.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit removes stale clang-related variables that are not used by
the bluetooth-tests workflow.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit removes stale clang-related variables that are not used by
the footprint-tracking workflow.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit removes stale clang-related variables that are not used by
the footprint workflow.

Signed-off-by: Stephanos Ioannidis <[email protected]>
`CLANG_ROOT_DIR` is deprecated; use `LLVM_TOOLCHAIN_PATH` instead.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit updates the CI workflows to use the CI image 0.24.3, in
order to pull in the LLVM/Clang 15 and Renode 1.13.1.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit updates the Clang workflow to build tests using Clang 15.

Signed-off-by: Stephanos Ioannidis <[email protected]>
@stephanosio stephanosio marked this pull request as ready for review September 8, 2022 17:59
@stephanosio stephanosio added the DNM This PR should not be merged (Do Not Merge) label Sep 8, 2022
@stephanosio
Copy link
Member Author

stephanosio commented Sep 8, 2022

Ready for review.

DNM until the MI is updated

Copy link
Contributor

@andyross andyross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complaints here. Whose binaries are you using, specifically? I should probably pull and try them.

@stephanosio
Copy link
Member Author

No complaints here. Whose binaries are you using, specifically? I should probably pull and try them.

The official binaries from the LLVM Project:
https://github.com/zephyrproject-rtos/docker-image/blob/daca905ddc589670b8f9edd39f21517ae146cfaa/Dockerfile#L169-L173

@andyross
Copy link
Contributor

andyross commented Sep 8, 2022

OK, thanks. (Frustratingly they don't have bare linux binaries, just ubuntu packages, but whatever, I guess I can run it in docker).

Those check out for me and do everything I'm currently doing with clang 14. They don't, frustratingly, fix the issue I'm having with the SOF fuzzer where ASAN will detect a "stack-overflow" on an instruction fetch once it returns to the fuzzing stub (which it was running successfully earlier!) after OS initialization. I was hoping to get a magic fix there, but I guess I have some work to do.

Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stephanosio !

@stephanosio stephanosio added this to the v3.3.0 milestone Sep 12, 2022
@jeremybettis jeremybettis removed their request for review September 12, 2022 17:23
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants